feat: nested groups #126
Open
feat: nested groups #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the feature described in #43.
Because there wasn't a definitive agreement on how this should be implemented I just chose one of the suggestions and implemented it. However I'd be glad to change anything if requested.
I'd appreciate any feedback, especially on the
suite.group.only()andsuite.group.skip()functions. They feel a bit hacky but I didn't have a better idea.I also added tests and an example to demonstrate how the feature currently works. Updated documentation too, although not sure whether
index.d.tsis .gitignore'd intentionally, or just a problem with my setup.Let me know what you think.