DM-40853: Implement new source injection for AP #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoSanchez
force-pushed
the
tickets/DM-40853
branch
from
a866e82 to
290f9fb
Compare
BrunoSanchez
force-pushed
the
tickets/DM-40853
branch
from
290f9fb to
5f8f858
Compare
isullivan
approved these changes
Jul 11, 2024
| # Creation of fakes_visitSummary | ||
| consolidateVisitSummary: | ||
| class: lsst.pipe.tasks.postprocess.ConsolidateVisitSummaryTask | ||
| config: | ||
| connections.calexpType: parameters.fakesType | ||
| connections.calexp: "{calexpType}calexp" | ||
| connections.calexp: "{calexpType}initial_pvi" |
There was a problem hiding this comment.
Here and below, should this be {fakesType} instead of {calexpType}?
There was a problem hiding this comment.
I don't think so. As the parameter template inside the task is named calexpType and we point to the fakesType value already.
Bear in mind that this consolidation task is a very general task and not-ap specific, nor fakes-specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the new source injection AP implementation in
ap_pipeand these changes inap_verifymake use of them.The specific changes so far work for DECam.
sconsand/orstack-os-matrix)?ap_verify.pyon at least one of the standard datasets?For changes to metrics, the
print_metricvaluesscript fromlsst.verifywill be useful.