DM-48122: Remove ProcessCcd.yaml from ap_pipe #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mrawls
approved these changes
Jan 13, 2025
The two single-frame tasks (ISR and CalibrateImage) are more naturally defined in the AP pipeline itself. However, the processCcd subset is still needed for backward-compatibility. Including RunIsrWithCrosstalk.yaml still requires splicing, but one fewer level of it.
Now that ProcessCcd is no longer used by higher-level pipelines, it can be removed without consequences.
This change removes the last of the splicing, and the subset redefinition that requires. Code duplication in the ISR config itself is avoided by moving it to a config file.
In general, we want to run single-frame metrics with single-frame processing. Previously, this was impractical because the tasks and subsets were defined in different places.
kfindeisen
force-pushed
the
tickets/DM-48122
branch
from
eca26b4 to
76d6c17
Compare
The name "processCcd" is a throwback to the Gen 2 ProcessCcdTask, and is not intuitive for new users who've only known Gen 3. The replacement name apPipeSingleFrame conveys the term "single-frame processing" (which is still in use) while distinguishing between the subset of ApPipe and the standalone SingleFrame pipeline (which are conceptually different enough that they must not be mixed up).
kfindeisen
force-pushed
the
tickets/DM-48122
branch
from
76d6c17 to
4a480dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
ProcessCcd.yamlandRunIsrWithCrosstalk.yaml, moving their contents into the main pipelines and a config file, respectively. This change removes all pipeline splicing fromap_pipe(though we still have some inap_verify).With the removal of
ProcessCcd.yaml, this PR also deprecates theprocessCcdsubset, replacing it withapPipeSingleFrame.