tickets/DM-47318 - change getRegionTimeFromVisit inputs #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerenjie
changed the title
kfindeisen
approved these changes
Nov 6, 2024
Comment on lines
-226
to
+228
| # Run getRegionTimeFromVisit as late as possible | ||
| - contract: transformDiaSrcCat.connections.ConnectionsClass(config=transformDiaSrcCat).diaSourceTable.name == | ||
| - contract: calibrateImage.connections.ConnectionsClass(config=calibrateImage).stars_footprints.name == | ||
| getRegionTimeFromVisit.connections.ConnectionsClass(config=getRegionTimeFromVisit).dummy_visit.name | ||
| msg: "transformDiaSrcCat.diaSourceTable != getRegionTimeFromVisit.dummy_visit" | ||
| msg: "calibrateImage.stars_footprints != getRegionTimeFromVisit.dummy_visit" |
There was a problem hiding this comment.
If we no longer particularly care when getRegionTimeFromVisit is run, do we still need a contract? If now we need it to be run no later than right after calibrateImage, a comment would be helpful.
| @@ -269,7 +269,7 @@ contracts: | |||
| - contract: calibrateImage.connections.ConnectionsClass(config=calibrateImage).stars_footprints.name == | |||
| getRegionTimeFromVisit.connections.ConnectionsClass(config=getRegionTimeFromVisit).dummy_visit.name | |||
| msg: "calibrateImage.stars_footprints != getRegionTimeFromVisit.dummy_visit" | |||
| - contract: getRegionTimeFromVisit.connections.ConnectionsClass(config=getRegionTimeFromVisit).output.name == | |||
| - contract: getRegionTimeFromVisit.connections.ConnectionsClass(config=getRegionTimeFromVisit).output.name == | |||
There was a problem hiding this comment.
Please squash this change onto the commit that introduced it.
Gerenjie
force-pushed
the
tickets/DM-47318
branch
from
6690ccb to
b8ffd0f
Compare
Gerenjie
force-pushed
the
tickets/DM-47318
branch
from
78bfb66 to
2b0face
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change contracts in ApPipe and ApPipeWithFakes to match the changes in pipe_task/getRegionTimeFromVisit's input.