DM-43180: Filter out old messages in fan-out service #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to figure out what is imported (and fixes a duplicate import that had slipped through the cracks).
The MESSAGE_EXPIRATION envvar sets the maximum allowed age of a message, in seconds. Ignoring old messages makes Prompt Processing more robust against network problems that cause large volumes of messages to be delivered at once. (The messages are not lost permanently; they can be processed in catch-up.)
kfindeisen
force-pushed
the
tickets/DM-43180
branch
from
b4e4b7a to
bf44a1b
Compare
hsinfang
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a timestamp-based filter that rejects old messages instead of forwarding them to Prompt Processing. Ignoring old messages makes Prompt Processing more robust against network problems that cause large volumes of messages to be delivered at once.
The filter is configured by a mandatory envvar,
MESSAGE_EXPIRATION, giving the maximum age in seconds.