DM-43646: Add nextVisit info to fan-out status logs #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
force-pushed
the
tickets/DM-43646
branch
from
a58385d to
5e244cd
Compare
kfindeisen
approved these changes
May 23, 2024
src/main.py
Outdated
Comment on lines
119
to
121
| info: `str` | ||
| Information such as some data IDs of the next visit message to identify | ||
| this request and to log with. |
There was a problem hiding this comment.
Maybe "some fields" instead of "some data IDs"? We're already used to "data ID" meaning something more specific.
src/main.py
Outdated
Comment on lines
413
to
415
| info = { | ||
| key: data[key] | ||
| for key in ["instrument", "groupId", "detector"] | ||
| } |
There was a problem hiding this comment.
The formatting here looks a bit odd; it took me a moment to parse that it was a dict comprehension and not a dict of two items. Can this fit on one line?
There was a problem hiding this comment.
Yes it can. That was black's choice, though.
Besides the groupId, the instrument and the detector of the nextVisit message are useful to identify a specific nextVisit message. Including them in the logs makes it easier to use the logs.
hsinfang
force-pushed
the
tickets/DM-43646
branch
from
5e244cd to
55f7ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.