DM-48560 : Allocate Resources during Daemon Iteration #162
+160
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcjennings
force-pushed
the
tickets/DM-48560/resources
branch
3 times, most recently
from
807e3c6 to
a1ff78e
Compare
tcjennings
force-pushed
the
tickets/DM-48099/no_templates
branch
from
2b8d70c to
9d696be
Compare
tcjennings
force-pushed
the
tickets/DM-48560/resources
branch
5 times, most recently
from
c476b40 to
54e9697
Compare
tcjennings
force-pushed
the
tickets/DM-48099/no_templates
branch
4 times, most recently
from
791f535 to
ddd6efd
Compare
tcjennings
force-pushed
the
tickets/DM-48560/resources
branch
2 times, most recently
from
81980e4 to
7116838
Compare
tcjennings
force-pushed
the
tickets/DM-48099/no_templates
branch
from
ddd6efd to
1397c3f
Compare
tcjennings
force-pushed
the
tickets/DM-48560/resources
branch
from
7116838 to
fc2c0e3
Compare
tcjennings
force-pushed
the
tickets/DM-48099/no_templates
branch
from
1397c3f to
d36e6d3
Compare
tcjennings
force-pushed
the
tickets/DM-48560/resources
branch
from
fc2c0e3 to
336a370
Compare
tcjennings
force-pushed
the
tickets/DM-48099/no_templates
branch
4 times, most recently
from
e900a60 to
931a0c3
Compare
tcjennings
force-pushed
the
tickets/DM-48560/resources
branch
6 times, most recently
from
9a0cc96 to
d8a2179
Compare
tcjennings
force-pushed
the
tickets/DM-48560/resources
branch
3 times, most recently
from
5275051 to
d9e51e5
Compare
tcjennings
force-pushed
the
tickets/DM-48099/no_templates
branch
from
931a0c3 to
b9cdf53
Compare
tcjennings
force-pushed
the
tickets/DM-48560/resources
branch
from
d9e51e5 to
2d3f8c3
Compare
Base automatically changed from
tickets/DM-48099/no_templates
to
tickets/DM-48099/release
February 6, 2025 18:10
mxk62
approved these changes
Feb 10, 2025
daues
approved these changes
Feb 10, 2025
| ), | ||
| "environment": f'"{submission_environment}"', | ||
| "initialdir": config.htcondor.working_directory, | ||
| "batch_name": config.htcondor.batch_name, |
There was a problem hiding this comment.
One question here on the 'batch_name'. it seems to be sent here as an attribute for the condor job, and I am not sure how this would be used. I suspect it could just be a placeholder, as the future. possible intention could be to add --constraint batch_name to the allocateNodes invocation. As is not sure what the job attribute will do.
There was a problem hiding this comment.
For now it is for potential bookkeeping as a potential future constraint.
tcjennings
force-pushed
the
tickets/DM-48560/resources
branch
from
2d3f8c3 to
de63992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(allocate): Allocate wms resources at end of daemon iteration
Note: this resource allocation is gated through a feature flag in the application's configuration, so it may be turned off when not needed. For instance, in the presence of an "official" allocateNodes loop for the production user account, this loop may not be required, but if an integration test needs to run as "quickly as possible" then it can be enabled for the duration; or, if running as a non-production account in a Dev environment, the allocation can be enabled for that specific deployment.