[0002] Root signatures: Fix example and reformat metadata schema #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inbelic
approved these changes
Oct 25, 2024
| #### Root Signature | ||
|
|
||
| ```LLVM | ||
| !3 = !{!4, !5, !6, !7 } |
There was a problem hiding this comment.
Suggested change
| !3 = !{!4, !5, !6, !7 } | |
| !3 = !{ !4, !5, !6, !7 } |
|
|
||
| ```llvm | ||
| !dx.rootsignatures = !{!2} ; list of function/root signature pairs | ||
| !2 = !{ptr @main, !3 } ; function, root signature |
There was a problem hiding this comment.
Suggested change
| !2 = !{ptr @main, !3 } ; function, root signature | |
| !2 = !{ ptr @main, !3 } ; function, root signature |
Not sure if needed, but everywhere else seems to have a space. There is another instance if this is the case on line 524
|
|
||
| * i32: the root signature flags ([D3D12_ROOT_SIGNATURE_FLAGS](d3d12_root_signature_flags)) | ||
|
|
||
|
|
|
|
||
| Operands: | ||
|
|
||
| * i32: the root signature flags ([D3D12_ROOT_SIGNATURE_FLAGS](d3d12_root_signature_flags)) |
There was a problem hiding this comment.
Suggested change
| * i32: the root signature flags ([D3D12_ROOT_SIGNATURE_FLAGS](d3d12_root_signature_flags)) | |
| * i32: the root signature flags ([D3D12_ROOT_SIGNATURE_FLAGS][d3d12_root_signature_flags]) |
Discrepancy with the other flag links
| * i32: number of descriptors in the range | ||
| * i32: base shader register | ||
| * i32: register space | ||
| * i32: descriptor range flgs ([D3D12_DESCRIPTOR_RANGE_FLAGS][d3d12_descriptor_range_flags]) |
There was a problem hiding this comment.
Suggested change
| * i32: descriptor range flgs ([D3D12_DESCRIPTOR_RANGE_FLAGS][d3d12_descriptor_range_flags]) | |
| * i32: descriptor range flags ([D3D12_DESCRIPTOR_RANGE_FLAGS][d3d12_descriptor_range_flags]) |
| ``` | ||
|
|
||
| Operands: | ||
| * i32: Filter ([D3D12_FILTER](d3d12_filter)) |
There was a problem hiding this comment.
These operands also use regular braces as opposed to square. Not sure which one is correct but I'll note it to double-check.
coopp
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the example metadata to the main proposal section.
Update the layout of the schema so that it is ordered more from top-to-bottom and reformat to be easier to read.
Also fixed the metadata example to match the schema.