Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TorchToLinalg] Fix AtenReflectionPad2dOp lowering to not assert when dimensions unknown #3758

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[TorchToLinalg] Fix AtenReflectionPad2dOp lowering to not assert when dimensions unknown #3758

wants to merge 2 commits into from
+12 −8

Conversation

giacs-epic
Copy link
Contributor

The asserts make the compiler crash (with a misleading error) also when vertical or horizontal dimensions are unknown (which is a valid state at this stage).

zjgarvey
zjgarvey requested changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Does the conversion even work if the input shape is dynamic? Can we add a dynamic test (either a lit test or preferably an e2e test) to make sure that path actually works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjgarvey zjgarvey zjgarvey requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giacs-epic @zjgarvey