Link against installed libc++/libc++abi when bootstrapping #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
vitalybuka
approved these changes
Nov 7, 2024
Created using spr 1.3.6-beta.1 [skip ci]
arichardson
changed the base branch from
users/arichardson/spr/main.link-against-installed-libclibcabi-when-bootstrapping
to
main
arichardson
deleted the
users/arichardson/spr/link-against-installed-libclibcabi-when-bootstrapping
branch
arichardson
added a commit
to llvm/llvm-project
that referenced
this pull request
Nov 7, 2024
This was needed before #115077 since the compiler-rt test build made assumptions about the build layout of libc++ and libc++abi, but now they link against a local installation of these libraries so we no longer need this workaround. The last attempt at landing this was reverted due to buildbot failures which should be fixed by llvm/llvm-zorg#299. Pull Request: #115379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build tree layout does not necessarily match a valid libc++
installation tree, so install libc++/libc++abi first.
This is needed for llvm/llvm-project#115379