Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use static files instead of online #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

chasays
Copy link

@chasays chasays commented Mar 18, 2024

No description provided.

@cmatthew
Copy link
Contributor

Any legal or license implications for hosting a copy of this project in our source?

@cmatthew
Copy link
Contributor

I think we need to at least include the Licence files from these projects, if they are compatible.

@chasays
Copy link
Author

chasays commented Mar 19, 2024

I think we need to at least include the Licence files from these projects, if they are compatible.

add license contexts from official page, pls review again

background-position: center right;
}
table.dataTable thead .sorting {
background-image: url("../images/sort_both.png");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't these relative images also need inclusion?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't these relative images also need inclusion?

I think yes.

@TamarChristinaArm
Copy link
Contributor

I think we need to at least include the Licence files from these projects, if they are compatible.

add license contexts from official page, pls review again

I think what @cmatthew was saying is that we have to include the full license https://github.com/DataTables/DataTables/blob/master/license.txt not just the copyright header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants