Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unrendered math #399

Merged
merged 1 commit into from
May 17, 2020
Merged

Fix unrendered math #399

merged 1 commit into from
May 17, 2020

Conversation

whzup
Copy link
Collaborator

@whzup whzup commented May 5, 2020

Description

Fixed some math that was badly rendered in the documentation and examples.

Related Issue

#389

Motivation and Context

We want the documentation to stay up to date and clean.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

There were spaces in the inline math. In the documentation of the handlers there was a CR missing.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@stevenbw
Copy link
Collaborator

stevenbw commented May 5, 2020

Thanks for kicking this off 😄

Is this PR just for the Tex parts that haven't rendered? Might be worth splitting #389 across multiple PRs.

@whzup
Copy link
Collaborator Author

whzup commented May 9, 2020

Yes, currently only the TeX parts 😄 Would be a good idea to split it up, but we need something like a TODO list first to see what belongs where 😕

@ljvmiranda921 ljvmiranda921 self-requested a review May 13, 2020 21:05
@ljvmiranda921
Copy link
Owner

Hey @whzup and @stevenbw , is this good for review? There's still a WIP tag so I'm assuming this is still work-in-progress.

I agree that we should split this to multiple PRs. I create one big Issue and pinned it down so that it can be the focus of our work as well. Let me update that Issue to specify which one fits into what so that we can separate these tasks

@whzup whzup changed the title [WIP] Update documentation Fix unrendered math May 14, 2020
@whzup whzup added documentation Documentation improvements or fixes tech-debt Related issues for improving baseline Pyswarms performance and documentation this 2020 labels May 14, 2020
@ljvmiranda921 ljvmiranda921 merged commit 48d58bd into ljvmiranda921:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation improvements or fixes tech-debt Related issues for improving baseline Pyswarms performance and documentation this 2020
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants