-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry 2 upgrade (PEP612-conformity) and gh-actions renovation #364
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
==========================================
- Coverage 63.43% 63.38% -0.06%
==========================================
Files 63 63
Lines 8982 8980 -2
Branches 2574 2572 -2
==========================================
- Hits 5698 5692 -6
- Misses 2665 2669 +4
Partials 619 619 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty straightforward.
ideally the changes to the actions would be in a separate PR so they don't hold up the changes to pyproject.toml (idk what needs to get done there to get the CD working), but this looks fine aside from two minor changes in pyproject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, hadn't looked at this action before. I am not exactly sure what the point is, because unless we are looking at the results of this run regularly it doesn't rly force us to do anything and isn't visible e.g. on PRs? This would probably be easier to do by just running pip install
rather than poetry if the intention is to test against the deps people would get if they installed normally.
Just passing thoughts, not needed to change in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependabot makes PRs . It updates hashes so using hashes looses its pain. See here for an example PR. If desired it can automerge or assign to someone; I prefer to merge myself after short review of changes (which are also conveniently linked in the PRs).
The dependabot config in this PR only looks for action-updates but not for python-package updates (I am unsure if you thought it would touch Python packages because you mentioned pip
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I thought your comment was on dependabot, now I see its on check-dependencies.yaml
. - I just updated it. I don't know why its present in the repo.
homepage = "https://github.com/linkml/linkml-runtime" | ||
repository = "https://github.com/linkml/linkml-runtime" | ||
documentation = "https://github.com/linkml/linkml-runtime" | ||
|
||
readme = "README.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readme = "README.md" | |
readme = { file = "README.md", content-type = "text/markdown" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked it up: If the file path ends in a case-insensitive .md suffix, then tools MUST assume the content-type is text/markdown.
So we don't need to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh that's a nice little touch :)
@sneakers-the-rat requested changes done. Thank you for the thorough and quick review! If the core maintainers would like to have this split I could to it. But I think it is not very useful to update the action-scripts just a little bit to make the updated |
what da heck is windows doing lol https://github.com/linkml/linkml-runtime/actions/runs/13048917327/job/36404669816?pr=364 |
Oh. I have never seen something like that locally on Win10/11. But I vaguely remember reading somewhere that the windows runner uses a c: and d: drive somehow. ...will have a look. Will also look at the unix failure. Earlier there was no problem, but maybe the job got cancelled before running due to the default use of fail-fast and the (expected) windows failure. Update: Unix is fine now. |
The problem on Windows is caused by a library used by poetry 2 that uses os.relpath for one dir on |
6b36667
to
f442a34
Compare
dd066a3
to
ace5228
Compare
028578f
to
c3d474b
Compare
Solved the problem for poetry 2 by using So now it is ready for review. The remaining windows issues are as expected until #360 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after loving it while it was the only tool of its kind, i have grown to really not like poetry - this looks like it was a lot more work than it should have been, it always is. other packaging tools make lockfiles without all the drama. glad poetry finally relented and implemented it, and thanks for doing that work <3
cabf9ea
to
c3d474b
Compare
For the failures of |
dda7ac9
to
f62a4a3
Compare
On ubuntu-latest the poetry-dynamic-versioning plugin also did not work when auto-installed, see version So I changed the actions to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also looks good to me. I appreciate your cleaning things up a little here as well. What is our strategy for fixing the windows build failures?
Merging #360? 😉 - It just needs another review. |
idk how pipx works but i'm noticing it's getting the wrong python version here - https://github.com/linkml/linkml-runtime/actions/runs/13116111241/job/36590689408?pr=364#step:6:16 maybe because |
It does not matter which version is used by pipx. It is isolated from the Python installed for the workflows. pipx uses the default Python version of the runner. |
pyproject.toml
to PEP612 style for poetry 2.xpypi-publish
action for trusted publishing; it is commented out now since you need to change the configuration in PyPI as well to enable it. Note that the env name is notpypi
as in the screenshots of the PyPI-docs butpypi-release
.Ignore the windows test failures or merge #360 first. 😄
Closes linkml/linkml#2520