remove x/net/http2 dependency #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iredelmeier
reviewed
Oct 22, 2018
achille-roussel
force-pushed
the
remove-http2-dependency
branch
from
63fdd4d to
c0465b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up from our conversation in #149
The http client implementation was using
http.Transportfor plain http, andhttp2.Transportfor https, which is already the default behavior of the standard library (since http2 support was introduced in Go 1.6).It seems like the extra dependency on
x/net/http2is unnecessary and the lightstep client could use the default http transport without losing any features.The PR also fixes support for http proxies, and adds a couple of sane defaults for various configuration options of the http transport.