Some assorted fixes #12274
Open
Some assorted fixes #12274
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like a copy and paste error.
slouken
reviewed
Feb 12, 2025
| @@ -346,7 +346,7 @@ void SDL_SendPenTouch(Uint64 timestamp, SDL_PenID instance_id, SDL_Window *windo | |||
| if (eraser && ((input_state & SDL_PEN_INPUT_ERASER_TIP) == 0)) { | |||
| input_state |= SDL_PEN_INPUT_ERASER_TIP; | |||
| send_event = true; | |||
| } else if (!down && (input_state & SDL_PEN_INPUT_ERASER_TIP)) { | |||
| } else if (!eraser && (input_state & SDL_PEN_INPUT_ERASER_TIP)) { | |||
There was a problem hiding this comment.
I don't think this change is correct. I think eraser is just a flag to know whether the contact tool is an eraser, and the down flag tells whether it's in contact or not. @icculus, can you confirm?
slouken
reviewed
Feb 12, 2025
| @@ -1518,6 +1518,7 @@ static SDL_sensorlist_item *GetSensor(SDL_joylist_item *item) | |||
| return NULL; | |||
| } | |||
| if (ioctl(fd_item, EVIOCGUNIQ(sizeof(uniq_item) - 1), &uniq_item) < 0) { | |||
| close(fd_item); | |||
There was a problem hiding this comment.
This looks like a good fix, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenscanHub found a bunch of issues in the SDL3 code, which may or may not be false positives.
I think that the 2 attached patches fix an actual problem and I ask to review and apply them.