Support for symfony 4 (and 3.4) #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allowing symfony 4 usage
lexik_currency.adapter_collector should be public for this bundle to work but sf4 changes every service to private by default
Added modern versions of php - 7.1 + 7.2 Added new symfony versions 3.4 and 4.0
enforcing phpunit 5.7 (default verstion for php 7 is phpunit 6 and it is not compatible with old tests)
Adding phpunit to requirement to safely running test and avoiding phpunit 6 problems
Removed custom phpunit install
fixed syntax error in json file
less strict phpunit version
improved version requirements
|
Obviously symfony 4 won't work on php <7.1 so travis script needs to be adjusted. |
|
@lexikteam Would you please review this. |
mabzzz
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 3.4 is already out and should be supported. PHP 7.1 and 7.2 should also be no-problem update. The real chalange is symfony 4 but my fork works for me so we all should be fine