Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove phantom stuff #3782

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

remove phantom stuff #3782

wants to merge 3 commits into from

Conversation

jimmywarting
Copy link

What:

  • Removed clone function as phantomjs isn't used anymore
  • also used for..of loop to avoid using a hosted variable and instead make it scoped

Why:

less code.

How:

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-dean matthew-dean matthew-dean left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmywarting @matthew-dean