Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): adding component optionin pallete #878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/theme/palette.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ declare module '@mui/material/styles' {
graphics?: {
default: string;
};
tabs?: string;
tertiary?: string;
hover?: string;
blur?: {
Expand Down Expand Up @@ -137,6 +136,7 @@ declare module '@mui/material/styles' {

/* Defines the palette containing border and icon color options.
To define any additional custom color options, you can extend the interface here.
component option has been added to allow more colors for various components
*/
interface Palette {
border: {
Expand All @@ -161,6 +161,10 @@ declare module '@mui/material/styles' {
alt: string;
};
};
//Defines the extended component color options used in the palette.
component: {
tabs?: string;
};
}

// Defines the options available for the palette.
Expand All @@ -187,6 +191,9 @@ declare module '@mui/material/styles' {
alt: string;
};
};
component: {
tabs?: string;
};
}
}

Expand All @@ -195,7 +202,6 @@ export const lightModePalette: PaletteOptions = {
default: Colors.charcoal[100],
secondary: Colors.accentGrey[90],
tertiary: Colors.accentGrey[80],
tabs: Colors.charcoal[70],
hover: Colors.charcoal[90],
supplementary: Colors.accentGrey[40],
blur: {
Expand Down Expand Up @@ -282,6 +288,9 @@ export const lightModePalette: PaletteOptions = {
disabled: Colors.charcoal[50]
}
},
component: {
tabs: Colors.charcoal[70]
},
border: {
default: Colors.charcoal[90],
strong: Colors.charcoal[30],
Expand Down Expand Up @@ -311,7 +320,6 @@ export const darkModePalette: PaletteOptions = {
default: Colors.charcoal[10],
secondary: Colors.accentGrey[20],
tertiary: Colors.accentGrey[30],
tabs: Colors.charcoal[110],
hover: Colors.charcoal[20],
supplementary: Colors.accentGrey[40],
blur: {
Expand Down Expand Up @@ -377,6 +385,9 @@ export const darkModePalette: PaletteOptions = {
},
surfaces: Colors.accentGrey[10]
},
component: {
tabs: Colors.charcoal[70]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SAHU-01 i think you miss in any one the mode to put different color, both are here same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies it's charcoal[110] sorry will update it.

},
text: {
default: Colors.charcoal[100],
secondary: Colors.charcoal[40],
Expand Down
Loading