Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Modal #731

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

sudhanshutech
Copy link
Member

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Yashsharma1911 and others added 17 commits July 11, 2024 16:41
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
Signed-off-by: Yash Sharma <[email protected]>
@leecalcote
Copy link
Member

@Yashsharma1911 look good?

Copy link
Member

@Yashsharma1911 Yashsharma1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou Suandhanshu, LGTM

src/custom/ShareModal/style.tsx Show resolved Hide resolved
src/custom/ShareModal/style.tsx Show resolved Hide resolved
@aabidsofi19 aabidsofi19 self-requested a review September 16, 2024 14:51
@leecalcote
Copy link
Member

merge conflict

@leecalcote
Copy link
Member

@Yashsharma1911 @sudhanshutech please address the merge conflict.

@Yashsharma1911
Copy link
Member

Conflict Resolved ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants