Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance logic to display thumbnail based on theme #6083

Merged
merged 2 commits into from
Nov 15, 2024
Merged

enhance logic to display thumbnail based on theme #6083

merged 2 commits into from
Nov 15, 2024

Conversation

vishalvivekm
Copy link
Contributor

Description

This PR:
image
image

Notes for Reviewers

Also adds birth of kanvas logo video as iframe:
image

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/news A noteworthy article, event, happening label Nov 15, 2024
@l5io
Copy link
Contributor

l5io commented Nov 15, 2024

🚀 Preview for commit ce46253 at: https://6737bd44092fe6674519e136--layer5.netlify.app

@leecalcote
Copy link
Member

@vishalvivekm all News items are compatible?

@leecalcote leecalcote merged commit a237528 into layer5io:master Nov 15, 2024
5 checks passed
@vishalvivekm
Copy link
Contributor Author

@vishalvivekm all News items are compatible?

@leecalcote
Not all existing news articles have a darkthumbnail, and in that case, we just use thumbnail ( which is present in all of 'em).

@leecalcote
Copy link
Member

@vishalvivekm, good work. That works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote Awaiting requested review from leecalcote

Assignees
No one assigned
Labels
area/news A noteworthy article, event, happening
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishalvivekm @l5io @leecalcote