Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sistent-divider-component #6048

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add sistent-divider-component #6048

wants to merge 5 commits into from

Conversation

mdkaifansari04
Copy link
Contributor

Description
Added Sistent Divider component with detailed documentation and clean examples
This PR fixes #5917

Notes for Reviewers
Docs Screenshots
image
image
image

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added area/projects An issue relating to Layer5 initiatives (projects) project/sistent labels Nov 1, 2024
@l5io
Copy link
Contributor

l5io commented Nov 1, 2024

🚀 Preview for commit b43e1fe at: https://672545b8e00adfb0dac1599f--layer5.netlify.app

@nebula-aac nebula-aac self-requested a review November 2, 2024 20:51
@vishalvivekm
Copy link
Member

@mdkaifansari04
Let's discuss this on websites call on Monday at 6:30 PM IST (7:00 AM CT). Add it as an agenda item to the meeting minutes, if you would :)

@mdkaifansari04
Copy link
Contributor Author

I'll be happy to discuss this on meeting

@l5io
Copy link
Contributor

l5io commented Nov 5, 2024

🚀 Preview for commit c1efa8c at: https://672a90c2dd3a3756f3b53764--layer5.netlify.app

@Vidit-Kushwaha
Copy link
Contributor

Hello, @mdkaifansari04, can you remove the excess indentation from the array of code in the code example so that it looks more uniform?

@mdkaifansari04
Copy link
Contributor Author

Sure I'll consider fixing that @Vidit-Kushwaha

@mdkaifansari04
Copy link
Contributor Author

@Vidit-Kushwaha Can you please check it, if its perfect now

@l5io
Copy link
Contributor

l5io commented Nov 6, 2024

🚀 Preview for commit 82201de at: https://672bc9cf447ceb3ac104eed3--layer5.netlify.app

@NishantSinghhhhh
Copy link
Contributor

You PR looks fine , but it will look more good if you add a section in which you will explain about the Props that will be used while working with this component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebula-aac nebula-aac nebula-aac approved these changes

Assignees
No one assigned
Labels
area/projects An issue relating to Layer5 initiatives (projects) project/kanvas project/sistent
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sistent] Add Divider component to the sistent components page
6 participants
@mdkaifansari04 @l5io @vishalvivekm @Vidit-Kushwaha @NishantSinghhhhh @nebula-aac