-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding glow & hover effect to the clickable cards #5048
Conversation
Signed-off-by: Ahmed Fathalrhman Mahjoub <[email protected]>
🚀 Preview for commit e26105c at: https://652e77d391a45e0a3f35923e--layer5.netlify.app |
🚀 Preview for commit edabff0 at: https://652e9a4270ab88101d98f194--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for clarification purposes, based on feedback from @Mohith234 based on the issue description as I've understood it, the goal is to update the styling on the specified cards so that on hover they have the "whitish-color" glow effect on the border and when not hovered (initial state) on they should have a green glowing border. However @Mohith234 you suggest that initially, the cards should not have the green glowing border (remain as they are currently in their pre-hover state) and only have the styling for the green glow effect on the border after hover. @xbelix perhaps you can update the issue description with a link to the "expected behaviour" cards, if the goal is to replicate the initial and on-hover styling for the indicated cards? This might make the expectations (if I understood the issue description as stated above) of the end goal clearer, as there are other cards that are styled differently within the same website i.e initial state no glowing border, hover state "whitish-color" glowing border...then initial state no glowing border, hover state no glowing border? Otherwise, if this PR has replicated the initial and on-hover styling for the cards under "expected behaviour", then I suggest this PR be considered as a solution as it resolved exactly what was described in the issue description. |
@Mohith234 Alright I got it, I thought they want it to be similar to other cards in the website. @sandramsc Thank you for your clarifications, I understood it what exactly how to do it |
Signed-off-by: Ahmed F. Mahjoub <[email protected]>
🚀 Preview for commit e1bbcd7 at: https://6530fc61cc1b68044e3f45c4--layer5.netlify.app |
Hey @xbelix Let's discuss this on website call tomorrow at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes. |
Hey @xbelix Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes. |
Due to no response for now i am closing this pr , @xbelix if you want you can get reassigned and create a quick new pr. While making a pr ensure that there should no unnecessary line changes as it takes time for reviewers to review |
This PR fixes #5044
Signed commits