Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select #103

Draft
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Draft

Add select #103

wants to merge 2 commits into from

Conversation

Huholoman
Copy link

Hello,

We really like your Slack package in our company, but we noticed that the select feature is missing. As a result, I decided to create a PR to add it.

Could you please review the PR and let me know how I can improve it?

Cheers

@Huholoman Huholoman force-pushed the add-select branch 3 times, most recently from b8a54f9 to a0fc7f6 Compare January 31, 2025 13:53
@taylorotwell
Copy link
Member

Please remove final classes and strict type declarations.

Can you also provide usage examples?

@taylorotwell taylorotwell marked this pull request as draft February 5, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants