Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Updaing 'JSON Schema' code block output #28909

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Docs: Updaing 'JSON Schema' code block output #28909

merged 2 commits into from
Dec 26, 2024

Conversation

ahmadelmalah
Copy link
Contributor

Out seems outdate, I ran the example several times and this is the updated output, one key-value pair was missing!
image

@vercel Vercel
Copy link

vercel bot commented Dec 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 0:06am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Dec 24, 2024
ccurme
ccurme approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran the cell twice. First time there was no rating, the second time there was. It's not a required field so it's reasonable for the model to leave it out. But it seems to be populated in the other examples so OK to update for consistency's sake.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 26, 2024
@ccurme ccurme merged commit d46fddf into langchain-ai:master Dec 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadelmalah @ccurme