Support multi-session GPIO #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twasilczyk
force-pushed
the
multisession
branch
from
17b8cca to
320b6a3
Compare
Verified with FT4232H Mini Module.
This allows implementing command-line tools that leave GPIO state after terminating themselves. This is a modified version of a change authored by Huihong Luo <[email protected]>
twasilczyk
force-pushed
the
multisession
branch
from
320b6a3 to
cc84c33
Compare
|
While I was able to fix low bits state, then this is still a PoC: I'm pretty sure pstart logic is broken with this change. I guess it should require setting only GPIO bits and leaving UART part as default. I didn't check concurrent GPIO + UART usage. |
|
We would need to make separate functions for reset-less open and close for compatibility. Otherwise looks good. Sadly, apparently i don't have an use case for such functionality yet, so can't improve/test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure about the logic around SET_BITS_HIGH. Especially that I don't have hardware to verify how the low bits operate with this change. Please treat this as a PoC change suggestion that we can work on.