refactor(dp-server): remove metadata tracker #12882
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were tracking the metadata in its own dataplane callbacks.
In practice this metadata was only used inside the sync_tracker which is itself a dataplane callback.
Implementation information
We now keep the metadata directly inside the sync_tracker and access it on each watchdog step.
This makes the code more streamlined and removes a hard to understand abstraction that added little value.
Supporting documentation
Part of #12881