Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshHealthCheck): deprecate HealthyPanicThreshold property for MeshHealthCheck policy #12878

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Icarus9913
Copy link
Contributor

@Icarus9913 Icarus9913 commented Feb 18, 2025

Motivation

We need to deprecate HealthyPanicThreshold property for MeshHealthCheck policy. Then we gonna supplement this field in MeshCircuitBreaker policy

Implementation information

Supporting documentation

Fix #11938

…eshHealthCheck and HealthCheck policies

Signed-off-by: Icarus Wu <[email protected]>
@Icarus9913 Icarus9913 requested a review from a team as a code owner February 18, 2025 06:12
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Signed-off-by: Icarus Wu <[email protected]>
Signed-off-by: Icarus Wu <[email protected]>
Signed-off-by: Icarus Wu <[email protected]>
@Icarus9913 Icarus9913 changed the title feat(MeshHealthCheck): deprecate HealthyPanicThreshold property for MeshHealthCheck and HealthCheck policies feat(MeshHealthCheck): deprecate HealthyPanicThreshold property for MeshHealthCheck policy Feb 18, 2025
Signed-off-by: Icarus Wu <[email protected]>
@Icarus9913
Copy link
Contributor Author

Update website: kumahq/kuma-website#2190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate HealthyPanicThreshold for MeshHealthCheck policy
2 participants