Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(upgrade.md): add doc for dataplane token revocation changes on Universal #12828

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jijiechen
Copy link
Member

Motivation

A supplementary change for PR #12788 to add upgrade.md changes.

The PR introduced a change to the DP authentication that impacts the behaviour of Universal clusters.

Implementation information

Add change entries in upgrade.md

Supporting documentation

@jijiechen jijiechen requested a review from a team as a code owner February 12, 2025 03:18
@jijiechen jijiechen added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Feb 12, 2025
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@lahabana lahabana changed the title chore(upgrade.md): add doc for dataplane token revocation changes on Universal docs(upgrade.md): add doc for dataplane token revocation changes on Universal Feb 13, 2025
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some docs to improve?

UPGRADE.md Outdated Show resolved Hide resolved
Signed-off-by: Jay Chen <[email protected]>
@jijiechen
Copy link
Member Author

Is there some docs to improve?

Created: kumahq/kuma-website#2189

@jijiechen jijiechen requested a review from lahabana February 20, 2025 02:04
@jijiechen jijiechen enabled auto-merge (squash) February 20, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants