-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce HealthyPanicThreshold
for MeshCircuitBreaker policy
#11704
Comments
Would that be something like: https://kuma.io/docs/dev/policies/meshcircuitbreaker/ outlierDetection:
panicDisabled: true
interval: 5s
baseEjectionTime: 30s
maxEjectionPercent: 20
splitExternalAndLocalErrors: true ? Also from looking at the docs I see no mention of panic, we should talk about it (kumahq/kuma-website#1953). Is there any possible workaround to set configuration in a way that will avoid entering panic? |
If you want to avoid entering panic mode, which means the upstream clusters keep in the healthy state and do not turn into unhealth. I guess maybe we just need to disable the Outlier detection ? And the upstream cluster would keep in health even they returned lots of failures. |
For now, I can just only use the MeshProxyPatch to disable the enovy-panic-threshold
|
Do we add envoy panic threshold by default even when you don't use MeshCircuitBreaker? @Icarus9913 |
I think we have it in MeshHealthCheck policy
|
@jakubdyszkiewicz I believe it's enabled by default in LoadBalancing of Envoy. And I was wondering if we could implement something like what Ilya put above. |
Maybe it's more proper to add a property We should also check the Istio's CircuitBreaker policy properties to check the differences and its source codes implementations. |
HealthyPanicThreshold
for MeshCircuitBreaker policy
Description
I noticed that there's an implementation difference between our MeshCircuitBreaker and Istio's (https://github.com/istio/istio/blob/7b2d8b9dacb7989d75b3b3d860988cadb9f5a848/pilot/pkg/networking/core/cluster_traffic_policy.go#L416-L423),
maybe we could add one flag to disable panic threshold and it depends on the user's choice.
The text was updated successfully, but these errors were encountered: