Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Release Signoff Checklist for KEP-3751 before GA #5024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Release Signoff Checklist for KEP-3751 before GA #5024

wants to merge 1 commit into from

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Jan 7, 2025 •
edited
Loading

  • One-line PR description: Update Release Signoff Checklist
  • Issue link:

/assign @msau42

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunnylovestiramisu
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2025
xing-yang
xing-yang reviewed Jan 14, 2025
View reviewed changes
keps/sig-storage/3751-volume-attributes-class/README.md
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
- [ ] (R) Graduation criteria is in place
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
- [ ] (R) Production readiness review completed
- [X] (R) Production readiness review completed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the entry for "stable" in the PRR file and tag a PRR approver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done once the GA flag is flipped in Kubernetes?

Copy link
Contributor

@xing-yang xing-yang Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant you need to add an entry for stable in the following file and ask a PRR reviewer to review it. For the KEP targeting GA in 1.33 to be merged, the PRR reviewer has to review and approve the PR as well.
https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-storage/3751.yaml
There is a PRR deadline (Thursday 6th February 2025: Week 4 — Production Readiness Freeze). Please update the KEP with this info by then. Flipping the GA flag in Kubernetes is part of implementation that needs to be done by the code freeze.

@xing-yang
Copy link
Contributor

  • Can you change the title "Kubernetes Volume Provisioned IO" to "Kubernetes Modify Volume" or "Kubernetes Volume Attributes Class"? It is not just about "provisioned io" any more.

  • "Stress test before GA" is in the Beta section. Do we have stress test?

  • This is in the PRR section "TODO Upgrade and rollback will be tested when the feature gate will change to beta." Is this still a TODO?

@xing-yang
Copy link
Contributor

It looks like this PR does not contain this merged change: https://github.com/kubernetes/enhancements/pull/5028/files
Do you need a rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunnylovestiramisu @k8s-ci-robot @xing-yang @msau42