Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Release Signoff Checklist for KEP-1495 Volume Populators #5023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Release Signoff Checklist for KEP-1495 Volume Populators #5023

wants to merge 1 commit into from
+44 −25

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Jan 7, 2025 •
edited
Loading

  • One-line PR description:
    Update Release Signoff Checklist from Template for KEP-1495 Volume Populators

/assign @msau42

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 7, 2025
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2025
@xing-yang
Copy link
Contributor

Please take a look at the latest template: https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template. I found the following sections are missing:

Monitoring Requirements:
How can someone using this feature know that it is working for their instance?

Scalability:
Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

Drawbacks

@xing-yang
Copy link
Contributor

In the Test Plan section, we should have a section for unit tests, integration tests, and e2e tests, each with a link to the test coverage and testgrid if available.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
@sunnylovestiramisu sunnylovestiramisu force-pushed the updateKEP branch 2 times, most recently from 9a66f87 to ad7dbd5 Compare January 16, 2025 16:15
@sunnylovestiramisu
Copy link
Contributor Author

/assign @deads2k

xing-yang
xing-yang reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you answer the following questions from the new KEP template?

Monitoring Requirements:
How can someone using this feature know that it is working for their instance?

Scalability:
Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

keps/sig-storage/1495-volume-populators/README.md

`DataSource` and `DataSourceRef` cannot be pointed to different resources.
While this is by design, it does not solve certain use case like restore volume
from VolumeSnapshot, and then do volume population.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand this use case. Can you elaborate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the VP KEP design: If DataSource is set valid AND DataSourceRef is set differently; reject

Which means DataSource and DataSourceRef cannot be different. The use case I described: customer sets snapshot in the DataSource field, creating a volume from the snapshot. And then do volume population via volume populator.

This case is currently not supported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, the volume population will overwrite the volume created from snapshot?

keps/sig-storage/1495-volume-populators/README.md
#### Integration Tests

- [pull-kubernetes-csi-lib-volume-populator dashboard](https://testgrid.k8s.io/sig-storage-csi-other#pull-kubernetes-csi-lib-volume-populator)
- [pull-kubernetes-csi-volume-data-source-validator dashboard](https://testgrid.k8s.io/sig-storage-csi-other#pull-kubernetes-csi-volume-data-source-validator)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include a link of the test code?
Looks like both tests failed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply here: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/testsuites/provisioning.go#L367

And I will update the pointer in the KEP.

Copy link
Contributor Author

@sunnylovestiramisu sunnylovestiramisu Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the test failure hmmm, need to look into it, I tried to do 'make all' also 'make test' locally on the lib-volume-populator it succeeded, also there is no new changes after Jan 2nd, and there was a sucess run on Jan 3rd.

The latest test runs are from dependabot PRs hmm? https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/pr-logs/directory/pull-kubernetes-csi-lib-volume-populator

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I triggered one test to run successfully on the dashboard: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-csi_lib-volume-populator/185/pull-kubernetes-csi-lib-volume-populator/1879962450263019520

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I couldn't find the test though. If I search for "VolumeSnapshotDataSource" or "should provision storage with snapshot data source", I can see a number of tests. If I search for "should provision storage with any volume data source", I couldn't find it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I screenshot and highlighted both:

vp-tests

keps/sig-storage/1495-volume-populators/README.md Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunnylovestiramisu
Once this PR has been reviewed and has the lgtm label, please ask for approval from deads2k, msau42. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@deads2k deads2k

@msau42 msau42

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sunnylovestiramisu @xing-yang @k8s-ci-robot @deads2k @msau42