-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add What this PR does / why we need it section #7996
base: master
Are you sure you want to change the base?
Conversation
Hi @bmnidhin. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Priyanka Saggu <[email protected]>
Co-authored-by: Priyanka Saggu <[email protected]>
Thank you @bmnidhin. Please squash the commits to one. /lgtm /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmnidhin, Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Pull template don't have a
What this PR does / why we need it:
section so contributes needed to add that heading manually. This PR adds that to the template. Used the same wording used here https://github.com/kubernetes/kubernetes/blob/a2106b5f73fe9352f7bc0520788855d57fc301e1/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L28C6-L28C41It is added as a h2 level heading