-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs blog readme #7953
base: master
Are you sure you want to change the base?
Fix docs blog readme #7953
Conversation
Welcome @AnshumanTripathi! |
Hi @AnshumanTripathi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @reylejano |
@lavishpal: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use relative linking please instead of specifying the entire link?
970a361
to
3c76c2a
Compare
I have updated to use the relative but we use the complete URL in other places, for example - Lines 106 to 107 in 384d42f
|
That would be great - whether here or in another PR. /lgtm |
New changes are detected. LGTM label has been removed. |
e633521
to
60b0f79
Compare
Actually this might not be possible since the generator expects complete links. |
883c708
to
30497ed
Compare
Signed-off-by: Anshuman Tripathi <[email protected]> Use relative link Signed-off-by: Anshuman Tripathi <[email protected]> Revert "Use relative link" This reverts commit 02a9f8d. Use relative link Signed-off-by: Anshuman Tripathi <[email protected]> Update sig-docs readme Signed-off-by: Anshuman Tripathi <[email protected]> Revert "Update sig-docs readme" This reverts commit 60b0f79. Fix readme through sigs.yaml Signed-off-by: Anshuman Tripathi <[email protected]>
Signed-off-by: Anshuman Tripathi <[email protected]>
30497ed
to
7cc572b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AnshumanTripathi, lavishpal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anshuman Tripathi <[email protected]>
Which issue(s) this PR fixes:
Fixes # #7952