-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix 404 errors in container-runtime-interface.md #7948
base: master
Are you sure you want to change the base?
docs: fix 404 errors in container-runtime-interface.md #7948
Conversation
fix broken links in container-runtime-interface before: https://git.k8s.io/kubernetes/pkg/kubelet/cri/streaming after: https://github.com/kubernetes/kubernetes/tree/release-1.5/pkg/kubelet/server/streaming
The committers listed above are authorized under a signed CLA. |
Welcome @mukeshmahato17! |
Hi @mukeshmahato17. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mukeshmahato17 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mukeshmahato17.
Requested a change.
/ok-to-test |
@@ -5,7 +5,7 @@ | |||
CRI (_Container Runtime Interface_) consists of a | |||
specifications/requirements (to-be-added), | |||
[protobuf API](https://git.k8s.io/kubernetes/staging/src/k8s.io/cri-api/pkg/apis/runtime/v1/api.proto), | |||
and [libraries](https://git.k8s.io/kubernetes/pkg/kubelet/cri/streaming) | |||
and [libraries](https://github.com/kubernetes/kubernetes/tree/release-1.5/pkg/kubelet/server/streaming)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and [libraries](https://github.com/kubernetes/kubernetes/tree/release-1.5/pkg/kubelet/server/streaming)) | |
and [libraries](https://git.k8s.io/kubelet/pkg/cri/streaming) |
fix broken links in container-runtime-interface