-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add /test-by-label to run all jobs matching a label selector #306
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's add at least a basic test though?
@@ -149,6 +152,51 @@ func (tf *TestAllFilter) Name() string { | |||
return "test-all-filter" | |||
} | |||
|
|||
// TestByLabelFilter builds a filter for the automatic behavior of | |||
// `/testlabel selector`. This filter works the same way as TestAllFilter, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// `/testlabel selector`. This filter works the same way as TestAllFilter, but | |
// `/test-by-label selector`. This filter works the same way as TestAllFilter, but |
This PR adds a new command,
/test-by-label
, which works the same as/test all
, but restricts the result to the Prowjobs matching the given label selector. So you can do/test-by-label provider=kubevirt
, for example.