Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /test-by-label to run all jobs matching a label selector #306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Oct 19, 2024

This PR adds a new command, /test-by-label, which works the same as /test all, but restricts the result to the Prowjobs matching the given label selector. So you can do /test-by-label provider=kubevirt, for example.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xrstf
Once this PR has been reviewed and has the lgtm label, please assign cblecker for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2024
Copy link

netlify bot commented Oct 19, 2024

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 3411d6e
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/67141000d8ea6a0008a52ce1
😎 Deploy Preview https://deploy-preview-306--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@petr-muller
Copy link
Contributor

/cc

Copy link
Contributor

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's add at least a basic test though?

@@ -149,6 +152,51 @@ func (tf *TestAllFilter) Name() string {
return "test-all-filter"
}

// TestByLabelFilter builds a filter for the automatic behavior of
// `/testlabel selector`. This filter works the same way as TestAllFilter, but
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// `/testlabel selector`. This filter works the same way as TestAllFilter, but
// `/test-by-label selector`. This filter works the same way as TestAllFilter, but

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants