Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a column to multikueue indicating if it is connected to worker cluster #4335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add a column to multikueue indicating if it is connected to worker cluster #4335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apis/kueue/v1beta1/multikueue_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ type MultiKueueConfigSpec struct {
// +kubebuilder:storageversion
// +kubebuilder:resource:scope=Cluster

// +kubebuilder:printcolumn:name="Connected",JSONPath=".status.conditions[?(@.type=='Active')].status",type="string",description="MultiKueueCluster is connected"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the example in the issue I would assume this was destined for MultiKueueCluster.
Shouldn't this be above line 82?

// +kubebuilder:printcolumn:name="Age",JSONPath=".metadata.creationTimestamp",type="date",description="Time this workload was created"
// MultiKueueConfig is the Schema for the multikueue API
type MultiKueueConfig struct {
metav1.TypeMeta `json:",inline"`
Expand Down
12 changes: 11 additions & 1 deletion charts/kueue/templates/crd/kueue.x-k8s.io_multikueueconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,16 @@ spec:
singular: multikueueconfig
scope: Cluster
versions:
- name: v1beta1
- additionalPrinterColumns:
- description: MultiKueueCluster is connected
jsonPath: .status.conditions[?(@.type=='Active')].status
name: Connected
type: string
- description: Time this workload was created
jsonPath: .metadata.creationTimestamp
name: Age
type: date
name: v1beta1
schema:
openAPIV3Schema:
description: MultiKueueConfig is the Schema for the multikueue API
Expand Down Expand Up @@ -69,3 +78,4 @@ spec:
type: object
served: true
storage: true
subresources: {}
12 changes: 11 additions & 1 deletion config/components/crd/bases/kueue.x-k8s.io_multikueueconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,16 @@ spec:
singular: multikueueconfig
scope: Cluster
versions:
- name: v1beta1
- additionalPrinterColumns:
- description: MultiKueueCluster is connected
jsonPath: .status.conditions[?(@.type=='Active')].status
name: Connected
type: string
- description: Time this workload was created
jsonPath: .metadata.creationTimestamp
name: Age
type: date
name: v1beta1
schema:
openAPIV3Schema:
description: MultiKueueConfig is the Schema for the multikueue API
Expand Down Expand Up @@ -54,3 +63,4 @@ spec:
type: object
served: true
storage: true
subresources: {}