feat: Add a column to multikueue indicating if it is connected to worker cluster #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: highpon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mszadkow
reviewed
Feb 21, 2025
| @@ -113,6 +113,8 @@ type MultiKueueConfigSpec struct { | |||
| // +kubebuilder:storageversion | |||
| // +kubebuilder:resource:scope=Cluster | |||
|
|
|||
| // +kubebuilder:printcolumn:name="Connected",JSONPath=".status.conditions[?(@.type=='Active')].status",type="string",description="MultiKueueCluster is connected" | |||
There was a problem hiding this comment.
From the example in the issue I would assume this was destined for MultiKueueCluster.
Shouldn't this be above line 82?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
When retrieving information about multikueue resources via the kubectl get command, we are unable to determine whether the multikueue is connected to worker cluster or not. It would be more convenient to know if the multikueue is connected to worker cluster or not.
Which issue(s) this PR fixes:
Fixes #4334
Special notes for your reviewer:
Does this PR introduce a user-facing change?