-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra requirements.txt ref to the Docs #11497
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Armin Teimouri <[email protected]>
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @armin-x86. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: armin-x86 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at the Kubespray CI - pre-commit
job log and fix it.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Two scripts within the project,
inventory.py
anddownload_hash.py
, rely onYAML parsing
functionalities. Without theruamel.yaml
library referenced in requirements.txt, users on freshly installed systems or Python environments will encounter aModuleNotFoundError
when trying to execute the command:This error occurs because the ruamel.yaml library is not installed by default.
This should be indicated in
Installation docs
to provide more clarity.Which issue(s) this PR fixes:
Fixes https://github.com/kubernetes-sigs/kubespray/issues/4331
Does this PR introduce a user-facing change?