-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Travis CI for release binaries #334
Set up Travis CI for release binaries #334
Conversation
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 56.89% 56.78% -0.12%
==========================================
Files 19 19
Lines 907 907
==========================================
- Hits 516 515 -1
- Misses 338 339 +1
Partials 53 53
Continue to review full report at Codecov.
|
As far as I can tell, this looks good. I only have little experience with releasing via travis on Github, though. Can we somehow test this before merging? One minor nit: Before, we were building with |
PS: It would make sense to also adapt |
04165f6
to
1f53fb1
Compare
I've tagged a v0.3.0-rc.1 with this commit. I've manually marked it as pre-release. |
1f53fb1
to
77c224f
Compare
Addressed comments. |
77c224f
to
eaa9900
Compare
eaa9900
to
8f8ed08
Compare
Signed-off-by: Ahmet Alp Balkan <[email protected]>
8f8ed08
to
d247900
Compare
Signed-off-by: Ahmet Alp Balkan <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Btw, with github releases we can get the number of downloads pretty easily: curl -sLH 'Accept: application/vnd.github.v3+json' "https://api.github.com/repos/kubernetes-sigs/krew/releases" | \
jq 'map([{key: "release", value: .tag_name}, {key: "assets", value: ( .assets | map({key: .name, value: .download_count}) | from_entries )}]|from_entries) ' At least we will know how many users upgraded krew :) |
Exactly my thoughts. I wish we had an app that monitored that endpoint it over time so we could tell the delta by {day, month, year} to do some analytics. I have developed https://gh-downloads-dpyb4duzqq-uc.a.run.app/grpc-ecosystem/grpc-health-probe many months ago but it doesn't have any sort of persistent storage. |
Ref: #324.
Ref: #333.
Fixes #337.
/assign @corneliusweig