Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Travis CI for release binaries #334

Merged
merged 2 commits into from
Sep 10, 2019

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Sep 8, 2019

Ref: #324.
Ref: #333.

Fixes #337.
/assign @corneliusweig

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2019
@codecov-io
Copy link

codecov-io commented Sep 8, 2019

Codecov Report

Merging #334 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   56.89%   56.78%   -0.12%     
==========================================
  Files          19       19              
  Lines         907      907              
==========================================
- Hits          516      515       -1     
- Misses        338      339       +1     
  Partials       53       53
Impacted Files Coverage Δ
cmd/validate-krew-manifest/main.go 55.1% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1175a...eb062d9. Read the comment docs.

@corneliusweig
Copy link
Contributor

As far as I can tell, this looks good. I only have little experience with releasing via travis on Github, though. Can we somehow test this before merging?

One minor nit: Before, we were building with golang:alpine-1, which uses golang 1.13 (see https://github.com/docker-library/golang/blob/2909cfd3ecb769671eb8222eaf9a782a6aed024d/1.13/alpine3.10/Dockerfile). On Travis, we are still using golang 1.11. Can we bump that for our travis builds?

@corneliusweig
Copy link
Contributor

corneliusweig commented Sep 8, 2019

PS: It would make sense to also adapt hack/make-release-notes.sh with the new download URLs for the krew artifacts.

@ahmetb ahmetb force-pushed the travis-release-binary branch from 04165f6 to 1f53fb1 Compare September 8, 2019 23:51
@ahmetb
Copy link
Member Author

ahmetb commented Sep 9, 2019

I've tagged a v0.3.0-rc.1 with this commit. I've manually marked it as pre-release.
Sadly, there's still no clean way to auto-populate release message (#122) but it works.

@ahmetb ahmetb force-pushed the travis-release-binary branch from 1f53fb1 to 77c224f Compare September 9, 2019 01:18
@ahmetb
Copy link
Member Author

ahmetb commented Sep 9, 2019

Addressed comments.

@ahmetb
Copy link
Member Author

ahmetb commented Sep 9, 2019

I'm getting some weird errors after switching go: 1.13.x, might go back to 1.11.x.

image

Signed-off-by: Ahmet Alp Balkan <[email protected]>
@corneliusweig
Copy link
Contributor

/lgtm
/approve
Big 👍 for getting the migration to Travis done so quickly AND fixing this strange flags.Parse() bug.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 73ee7e2 into kubernetes-sigs:master Sep 10, 2019
@ahmetb ahmetb mentioned this pull request Sep 10, 2019
@corneliusweig
Copy link
Contributor

Btw, with github releases we can get the number of downloads pretty easily:

curl -sLH 'Accept: application/vnd.github.v3+json' "https://api.github.com/repos/kubernetes-sigs/krew/releases" | \
        jq 'map([{key: "release", value: .tag_name}, {key: "assets", value: ( .assets | map({key: .name, value: .download_count}) | from_entries )}]|from_entries) '

At least we will know how many users upgraded krew :)

@ahmetb
Copy link
Member Author

ahmetb commented Sep 10, 2019

Exactly my thoughts.

I wish we had an app that monitored that endpoint it over time so we could tell the delta by {day, month, year} to do some analytics.

I have developed https://gh-downloads-dpyb4duzqq-uc.a.run.app/grpc-ecosystem/grpc-health-probe many months ago but it doesn't have any sort of persistent storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.13 breaks 'go test' flags, possibly conflicting with glog flags
4 participants