Self nominate Kevin Hannon for approval rights #758
Conversation
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
the
size/XS
✅ Deploy Preview for kubernetes-sigs-jobset ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/hold /assign @ahg-g @danielvegamyhre |
k8s-ci-robot
added
the
do-not-merge/hold
| @@ -2,3 +2,4 @@ | |||
|
|
|||
| approvers: | |||
| - moficodes | |||
| - kannon92 | |||
There was a problem hiding this comment.
Do we need to update the site OWNERs since you are the root owner ?
| @@ -3,5 +3,6 @@ | |||
| approvers: | |||
| - ahg-g | |||
| - danielvegamyhre | |||
| - kannon92 | |||
| reviewers: | |||
| - kannon92 | |||
There was a problem hiding this comment.
I think, you can remove yourself from the reviewers.
|
@andreyvelich: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm Thanks for your contributions Kevin! |
k8s-ci-robot
added
the
lgtm
|
/assign @ahg-g |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
What type of PR is this?
/kind documentation
What this PR does / why we need it:
I have been active in JobSet since the beginning of the project.
I led a KEP for startup policy and I have closely worked with @andreyvelich on kubeflow training v2.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I'll use this as tracking list for PRs related to becoming a maintainer of jobset.
Does this PR introduce a user-facing change?