Add conformance report for NGINX Gateway Fabric v1.6.0 #3555

bjee19 · 2025-01-16T19:49:02Z

What type of PR is this?
/kind documentation
/area conformance

What this PR does / why we need it:

Which issue(s) this PR fixes:
Updates conformance report for NGINX Gateway Fabric v1.6.0. Also changes organization name of nginxinc to nginx.

Does this PR introduce a user-facing change?:
no

k8s-ci-robot · 2025-01-16T19:49:04Z

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

linux-foundation-easycla · 2025-01-16T19:49:06Z

The committers listed above are authorized under a signed CLA.

✅ login: bjee19 (d5b1cb5, 77f570a, bfc3a37, 1b0b2c4)

k8s-ci-robot · 2025-01-16T19:49:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bjee19
Once this PR has been reviewed and has the lgtm label, please assign danwinship, mikemorris for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

conformance/OWNERS
site-src/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-01-16T19:49:10Z

Welcome @bjee19!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-01-16T19:49:11Z

Hi @bjee19. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bjee19 · 2025-01-16T19:52:48Z

Apologies in advance for the organization name change from nginxinc->nginx, i know that it can be troublesome. Also, I am unsure if changes to the site-src/implementations/* docs are allowed, so please let me know if they aren't. TIA!

sjberman · 2025-01-16T19:58:24Z

site-src/implementations/v1.0.md

@@ -25,8 +25,8 @@ Implementations only appear in this page if they pass Core conformance for the r
 | envoyproxy      | envoy-gateway                      | v0.6.0        | :white_check_mark:        | :white_check_mark:            | :white_check_mark:                    | :white_check_mark:        | :white_check_mark:      | :white_check_mark:      | :white_check_mark:     | :white_check_mark:        | :white_check_mark:     | :x:                      | :white_check_mark:       | :white_check_mark:                | :white_check_mark:        |
 | istio           | istio                              | 1.2           | :white_check_mark:        | :white_check_mark:            | :white_check_mark:                    | :white_check_mark:        | :white_check_mark:      | :white_check_mark:      | :white_check_mark:     | :white_check_mark:        | :white_check_mark:     | :x:                      | :white_check_mark:       | :white_check_mark:                | :white_check_mark:        |
 | kumahq          | kuma                               | 2.6.0         | :white_check_mark:        | :white_check_mark:            | :white_check_mark:                    | :x:                       | :white_check_mark:      | :white_check_mark:      | :white_check_mark:     | :white_check_mark:        | :white_check_mark:     | :x:                      | :white_check_mark:       | :x:                               | :x:                       |
-| nginxinc        | nginx-kubernetes-gateway           | v1.1.0        | :white_check_mark:        | :white_check_mark:            | :x:                                   | :x:                       | :white_check_mark:      | :x:                     | :white_check_mark:     | :white_check_mark:        | :white_check_mark:     | :x:                      | :x:                      | :x:                               | :x:                       |
-| nginxinc        | nginx-gateway-fabric               | v1.2.0        | :white_check_mark:        | :white_check_mark:            | :x:                                   | :x:                       | :white_check_mark:      | :x:                     | :white_check_mark:     | :white_check_mark:        | :white_check_mark:     | :x:                      | :x:                      | :x:                               | :x:                       |
+| nginx           | nginx-kubernetes-gateway           | v1.1.0        | :white_check_mark:        | :white_check_mark:            | :x:                                   | :x:                       | :white_check_mark:      | :x:                     | :white_check_mark:     | :white_check_mark:        | :white_check_mark:     | :x:                      | :x:                      | :x:                               | :x:                       |


I think these charts are auto-generated when the site is built, and may not need to be manually changed. But I'll let someone else confirm that.

That makes sense, I ran make generate and didn't see the changes so I knew at least locally it wasn't updated through that, but we can wait on a confirmation.

Good question - @xtineskim probably knows best here as far as how this is supposed to work.

yes you're correct @sjberman , the chart is auto-generated when the site is built 👍
LGTM

removed the changes to the auto-generated charts! thanks

You can keep them in actually - so then the changes of the name are reflected in the conformance table 👀

Oops ok sorry, I misinterpreted what you meant, i'll add them back in!

We also shouldn't have nginx-kubernetes-gateway in there, that should be updated to nginx-gateway-fabric.

If there are any other references to nginx-kubernetes-gateway, they should be updated. Thought we got those a long time ago but maybe not.

mikemorris · 2025-01-16T21:21:35Z

/ok-to-test

bjee19 added 2 commits January 16, 2025 11:34

Add conformance report for v1.6.0

bfc3a37

Update nginxinc organization name to nginx

d5b1cb5

k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/conformance labels Jan 16, 2025

k8s-ci-robot requested review from howardjohn and mikemorris January 16, 2025 19:49

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 16, 2025

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 16, 2025

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 16, 2025

sjberman reviewed Jan 16, 2025

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2025

Revert name change in auto generated files

77f570a

bjee19 force-pushed the ngf-conformance-1.6 branch from 8103228 to 77f570a Compare January 17, 2025 17:55

Add back name change and change nginx kubernetes gateway to ngf

1b0b2c4

bjee19 force-pushed the ngf-conformance-1.6 branch from d6c24ce to 1b0b2c4 Compare January 17, 2025 18:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add conformance report for NGINX Gateway Fabric v1.6.0 #3555

Add conformance report for NGINX Gateway Fabric v1.6.0 #3555

bjee19 commented Jan 16, 2025

k8s-ci-robot commented Jan 16, 2025

linux-foundation-easycla bot commented Jan 16, 2025 •

edited

Loading

k8s-ci-robot commented Jan 16, 2025

k8s-ci-robot commented Jan 16, 2025

k8s-ci-robot commented Jan 16, 2025

bjee19 commented Jan 16, 2025

sjberman Jan 16, 2025

bjee19 Jan 16, 2025 •

edited

Loading

robscott Jan 17, 2025

xtineskim Jan 17, 2025 •

edited

Loading

bjee19 Jan 17, 2025

xtineskim Jan 17, 2025

bjee19 Jan 17, 2025 •

edited

Loading

sjberman Jan 17, 2025

mikemorris commented Jan 16, 2025

Add conformance report for NGINX Gateway Fabric v1.6.0 #3555

Are you sure you want to change the base?

Add conformance report for NGINX Gateway Fabric v1.6.0 #3555

Conversation

bjee19 commented Jan 16, 2025

k8s-ci-robot commented Jan 16, 2025

linux-foundation-easycla bot commented Jan 16, 2025 • edited Loading

k8s-ci-robot commented Jan 16, 2025

k8s-ci-robot commented Jan 16, 2025

k8s-ci-robot commented Jan 16, 2025

bjee19 commented Jan 16, 2025

sjberman Jan 16, 2025

Choose a reason for hiding this comment

bjee19 Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

robscott Jan 17, 2025

Choose a reason for hiding this comment

xtineskim Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

bjee19 Jan 17, 2025

Choose a reason for hiding this comment

xtineskim Jan 17, 2025

Choose a reason for hiding this comment

bjee19 Jan 17, 2025 • edited Loading

Choose a reason for hiding this comment

sjberman Jan 17, 2025

Choose a reason for hiding this comment

mikemorris commented Jan 16, 2025

linux-foundation-easycla bot commented Jan 16, 2025 •

edited

Loading

bjee19 Jan 16, 2025 •

edited

Loading

xtineskim Jan 17, 2025 •

edited

Loading

bjee19 Jan 17, 2025 •

edited

Loading