Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 e2e: properly label and cleanup created PVCs during e2e tests in prow #3361

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Adds cleanup of CNS volumes which are currently only created during node-drain tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 18, 2025
@chrischdi chrischdi changed the title e2e: properly label and cleanup created PVCs during e2e tests in prow 🌱 e2e: properly label and cleanup created PVCs during e2e tests in prow Feb 18, 2025
@chrischdi
Copy link
Member Author

/hold

Want to verify at team-cluster-api#59

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2025
@chrischdi chrischdi force-pushed the pr-capv-cleanup-cns-volumes branch from 882c047 to 0d261b8 Compare February 18, 2025 08:37
@chrischdi chrischdi force-pushed the pr-capv-cleanup-cns-volumes branch from 0d261b8 to 756c3c2 Compare February 18, 2025 08:42
@chrischdi
Copy link
Member Author

/label tight/merge-method-squash

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The label(s) /label tight/merge-method-squash cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label tight/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member Author

Not tight 🤦

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 18, 2025
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c0ecc3593a4f8ef3337f5f268da6cfbc0bebd86f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-main c491e64 link false /test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@chrischdi
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2025
@chrischdi
Copy link
Member Author

/override pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

@k8s-ci-robot
Copy link
Contributor

@chrischdi: Overrode contexts on behalf of chrischdi: pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

In response to this:

/override pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member Author

/override pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

@k8s-ci-robot
Copy link
Contributor

@chrischdi: Overrode contexts on behalf of chrischdi: pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

In response to this:

/override pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 092907a into kubernetes-sigs:main Feb 18, 2025
14 of 15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants