DNM: Revert "Revert "chore: bump golang to 1.23.5""

[damdo]

Reverts #1413

Reintroduce the original bump golang to 1.23.5 PR

This should merge only after CAPG v1.9 is cut, as CAPG v1.9 follows CAPI 1.9, which uses go 1.22.

/hold

until then

/cc. @cpanato @justinsb @richardcase @salasberryfin

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damdo
Once this PR has been reviewed and has the lgtm label, please assign chrischdi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name	Link
🔨 Latest commit	075352a
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/6793bd89d6df7300085f67dd
😎 Deploy Preview	https://deploy-preview-1414--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[barbacbd]

@damdo should this still be active/open with #1420 over-bumping to the next version of bug fixes?

[barbacbd]

/cc

[k8s-ci-robot]

@barbacbd: GitHub didn't allow me to request PR reviews from the following users: barbacbd.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damdo]

Hey @barbacbd yes we should favour this PR, over #1420.
That one only changes one file, this does it the complete way.

I'd err on the side of turning dependabot off for the go version bumps. Or teach it to bump in all of the places we care about, and only for the patch version (the minor go version is something we want to bump only once every CAPI minor release bump).

WDYT @cpanato @salasberryfin @richardcase ?

[richardcase]

I'd err on the side of turning dependabot off for the go version bumps.

Yes i think thats probably a good idea, same with kubernetes packages as they are done inline with CAPI.

[damdo]

Thanks @richardcase I tried the command here but it needs an approver for that. Would you be able to "comment" it yourself?