-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Bump CAPI to v1.9.z #1357
base: main
Are you sure you want to change the base?
WIP: Bump CAPI to v1.9.z #1357
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/test pull-cluster-api-provider-gcp-e2e-test |
@damdo: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
TODO: try and add something like https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/85759ceebd3a679b599b2dd9ded48eb945fbdc28/test/e2e/shared/common.go#L68 in the AfterSuite of the e2e tests to dump details before the teardown. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
CAPI v1.9.0-beta.0 is out now, so this PRs bumps the CAPI version used by CAPG to it.
Bumps CAPI to v1.9.z based on https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.8-to-v1.9.md
Special notes for your reviewer:
api-diff failing is expected as the API changed to a typed go generics function.
Checklist:
Release note: