Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Bump CAPI to v1.9.z #1357

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

WIP: Bump CAPI to v1.9.z #1357

wants to merge 3 commits into from

Conversation

damdo
Copy link
Member

@damdo damdo commented Nov 6, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

CAPI v1.9.0-beta.0 is out now, so this PRs bumps the CAPI version used by CAPG to it.

Bumps CAPI to v1.9.z based on https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.8-to-v1.9.md

Special notes for your reviewer:
api-diff failing is expected as the API changed to a typed go generics function.

Checklist:

  • squashed commits
  • adds or updates e2e tests

Release note:

Bump CAPI to v1.9.z

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 6, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: damdo
Once this PR has been reviewed and has the lgtm label, please assign richardcase for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 6, 2024
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 4e08d1e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/672b50bb06c67b000898e316
😎 Deploy Preview https://deploy-preview-1357--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@damdo
Copy link
Member Author

damdo commented Nov 6, 2024

/test pull-cluster-api-provider-gcp-e2e-test

@k8s-ci-robot
Copy link
Contributor

@damdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-gcp-apidiff 4e08d1e link false /test pull-cluster-api-provider-gcp-apidiff
pull-cluster-api-provider-gcp-e2e-test 4e08d1e link true /test pull-cluster-api-provider-gcp-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member Author

damdo commented Nov 7, 2024

TODO: try and add something like https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/85759ceebd3a679b599b2dd9ded48eb945fbdc28/test/e2e/shared/common.go#L68 in the AfterSuite of the e2e tests to dump details before the teardown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants