-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add UT for gen-disk-skus-map_test #2781
Conversation
Hi @Zhupku. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
can you squash all commits? thx |
1450df0
to
8148950
Compare
8148950
to
bdd1e59
Compare
@Zhupku: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, Zhupku The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request includes changes to the
pkg/tool/gen-disk-skus-map.go
file to improve code maintainability and the addition of a new test filepkg/tool/gen-disk-skus-map_test.go
.Code maintainability improvements:
exit
function to handle program termination, replacing direct calls toos.Exit
with calls to theexit
function. (pkg/tool/gen-disk-skus-map.go
) [1] [2] [3]Testing improvements:
pkg/tool/gen-disk-skus-map_test.go
to include a unit test for themain
function. This test verifies that the program exits with the expected code. (pkg/tool/gen-disk-skus-map_test.go
)<!-- Thanks for sending a pull request! Here are some tips for you:https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/release.md#issue-kind-label
-->
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: