-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #66 : select upto only 3 categories #78
FIX #66 : select upto only 3 categories #78
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for the PR, unfortunately this doesn't bind to our conversation while assigning the issue, kindly follow that, that is the acceptance criteria for this issue. |
@krishnaacharyaa hey all checks have been passed, please check the code as i have the addressed the suggestions given in the comment of issue #73 |
@vivek6201, there seems to be some communication gap,
As mentioned here, the task is to simply complete #73 (comment), and the rest of the implementation to be followed from #73, |
hey @krishnaacharyaa , changes have been made according to comments please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly follow the comment highlighted more than twice for now, take your time understand what is the requirement and come up with a solution, too much time is exhausted mutually explaining thing recursively.
You should just solve the comment #73, nothing plus nor minus, you tried doing everything except the thing requested... Just implement #73 (comment) |
sorry, as this is taking more than the desired time according to the issue. but, this code shold work now. @krishnaacharyaa, i request to check for the last time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick fix, looks good now, merging this.
p.s: kindly take care of the commit messages next time, the commit messages helps in the nice structuring of the code
Summary
To issue user should not add more than 3 categories.
Description
I have resolved the bug by checking the length of the categories array and stoped the user to add more category after the limit is reached, css is also added so that user can know that more category cannot be added.
Issue(s) Addressed
Closes #66
Prerequisites