Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-#379: Enhancing the footer by including GitHub and Discord for better feedback #430

Merged
merged 2 commits into from
Jun 25, 2024
+43 −6
Merged

fix-#379: Enhancing the footer by including GitHub and Discord for better feedback #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b44c32b
fix-#379: Enhancing the footer by including GitHub and Discord for be…
Lanthoiba2022 Jun 25, 2024
2674fb6
fix-#379: Requested changes made for Enhancing the footer by includin…
Lanthoiba2022 Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions frontend/src/assets/svg/discor.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions frontend/src/assets/svg/github.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
36 changes: 30 additions & 6 deletions frontend/src/layouts/footer-layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,38 @@
import GitHub_Icon from '@/assets/svg/github.svg';
import Discord_Icon from '@/assets/svg/discor.svg';
function footer() {
const newDate = new Date();
const year = newDate.getFullYear();

return (
<footer className="flex min-h-[6vh] flex-col items-center bg-zinc-900 py-2 text-center text-white sm:flex-row sm:justify-between sm:py-3">
<section className="text-base sm:pl-4 sm:pl-8 lg:pl-16">WanderLust</section>
<section className="text-base sm:pr-16 sm:pr-4 lg:pr-24">
<span className="mr-2">&copy;</span>
{year} All Rights Reserved
</section>
<footer className="flex min-h-[6vh] flex-col items-center bg-zinc-900 py-3 pt-10 text-center text-white sm:flex-row sm:justify-center sm:py-3">
<div className="mb-8 mt-8">
<section className="flex items-center text-xs sm:text-sm">
Find an issue with this page?{' '}
<span className="pl-1 text-blue-500">
<a href="https://github.com/krishnaacharyaa/wanderlust">Fix it on GitHub</a>
</span>
<span>
<a href="https://github.com/krishnaacharyaa/wanderlust">
<img src={GitHub_Icon} className="h-7 w-10" />
</a>
</span>
</section>

<section className="flex items-center pl-8 text-xs sm:text-sm">
Need help? Connect with us on
<span>
<a href="https://discord.com/invite/FEKasAdCrG">
<img src={Discord_Icon} className="h-6 w-10" />
</a>
</span>
</section>

<section className="mt-4 flex items-center pl-16 text-xs">
<span className="mr-2">&copy;</span>
{year} All Rights Reserved
</section>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it to 2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

year is taken using this method "const year = newDate.getFullYear();". Ig it's not to be hardcoded.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, sorry missed it

</div>
</footer>
);
}
Expand Down