fix-#6: integration test completed for signin component #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t , fixed unit test due to new changes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @Aswin2255! Thanks for sticking to the guidelines! High five! 🙌🏻 |
1 similar comment
|
Hey @Aswin2255! Thanks for sticking to the guidelines! High five! 🙌🏻 |
krishnaacharyaa
requested changes
Jun 11, 2024
| @@ -13,7 +13,7 @@ const app = express(); | |||
| app.use( | |||
| cors({ | |||
| // added origin | |||
| origin: FRONTEND_URL, | |||
| origin: [FRONTEND_URL, 'http://localhost:3000'], | |||
| credentials: true, | |||
There was a problem hiding this comment.
since we are doing an integration test with the real API. The jsdom is our frontend and it's default URL is localhost:3000, so if we doesn't include it we will get an cors error during integration test..
| @@ -2,7 +2,7 @@ | |||
| import { http, HttpResponse } from 'msw'; | |||
|
|
|||
| export const handlers = [ | |||
| http.post('http://localhost:5000/api/auth/email-password/signup', () => { | |||
| http.post('http://localhost:8080/api/auth/email-password/signup', () => { | |||
| return new HttpResponse(null, { | |||
| import { toast } from 'react-toastify'; | ||
|
|
||
| interface sucessdata { | ||
| status: number; |
There was a problem hiding this comment.
I see this used multiple places, can we have a seperate types folder? and make it reusable
krishnaacharyaa
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration test completed for the sign-in component fixed the unit case failure due to the new changes introduced
Summary
An integration test is performed on the sign-in component using the real backend API
Description
To perform the integration test we need to run the backend, also we need to have a test user in the database with the test credentials
Images
Issue(s) Address
#6
Prerequisites