Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-#77: changed the traditional form to react hook form #407

Merged
merged 3 commits into from
Jun 8, 2024
Merged

fix-#77: changed the traditional form to react hook form #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a22bc6a
fix-#77: changed the traditional form to react hook form
Ameerjafar Jun 7, 2024
067921b
chore-#177: Added the suggestions
Ameerjafar Jun 8, 2024
e3f4147
fix-#77: cleared the catagories field bug
Ameerjafar Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,22 @@
]
},
"dependencies": {
"@hookform/resolvers": "^3.3.4",
"@hookform/resolvers": "^3.5.0",
"@tsparticles/react": "^3.0.0",
"axios": "^1.6.1",
"class-variance-authority": "^0.7.0",
"clsx": "^2.0.0",
"lucide-react": "^0.292.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-hook-form": "^7.51.2",
"react-hook-form": "^7.51.5",
"react-router-dom": "^6.18.0",
"react-tag-input": "^6.8.1",
"react-toastify": "^9.1.3",
"tailwind-merge": "^2.0.0",
"tailwindcss-animate": "^1.0.7",
"tsparticles": "^3.4.0",
"zod": "^3.22.4"
"zod": "^3.23.8"
},
"devDependencies": {
"@babel/preset-env": "^7.23.6",
Expand Down
33 changes: 33 additions & 0 deletions frontend/src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,38 @@ export const signUpSchema = z
message: 'Confirm Password do not match',
path: ['confirmPassword'],
});
const isValidImageLink = (value: string) => {
const imageLinkRegex = /\.(jpg|jpeg|png|webp)$/i;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need a function? Can't we inline using the .validate option which zod provides directly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.validate is when we are giving some url to test whether that url meets the defined schema or not @krishnaacharyaa

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ameerjafar okay if we can't inline then fine, but i guess inline/arrow function can be written

return imageLinkRegex.test(value);
};
export const addBlogSchema = z.object({
title: z.string().refine((value) => value.trim().split(/\s+/).length >= 3, {
message: 'Oops! Title needs more spice. Give it at least 3 words.',
}),
isFeaturedPost: z.boolean(),
description: z.string().refine((value) => value.trim().split(/\s+/).length >= 10, {
message: 'Oops! Description needs more detail. Give it at least 10 words',
}),
authorName: z
.string()
.min(3, {
message: "C'ome on! Your name cannot be less than 3 characters.",
})
.max(15, {
message: "Hey isn't it too big of a name, can you limit it to 15 characters",
}),
imageLink: z.string().refine((value) => isValidImageLink(value), {
message: 'Hmm... Image link should end with .jpg, .jpeg, .webp, or .png.',
}),
categories: z
.array(z.string())
.min(1, {
message: 'Easy there! Select at least one category.',
})
.max(3, {
message: 'Easy there! Not more than 3 categories.',
}),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

});

export interface AuthData {
_id: string;
Expand All @@ -38,3 +70,4 @@ export interface AuthData {

export type TSignInSchema = z.infer<typeof signInSchema>;
export type TSignUpSchema = z.infer<typeof signUpSchema>;
export type TAddBlogScheme = z.infer<typeof addBlogSchema>;
Loading
Loading