chore: modify the darktheme in the add blog and fixed the eslint error #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @Ameerjafar! Thanks for sticking to the guidelines! High five! 🙌🏻 |
krishnaacharyaa
requested changes
May 28, 2024
| @@ -1,6 +1,6 @@ | |||
| import { HTTP_STATUS, RESPONSE_MESSAGES } from '../utils/constants.js'; | |||
|
|
|||
| const errorMiddleware = (err, req, res, next) => { | |||
| const errorMiddleware = (err, req, res) => { | |||
| console.error(err.stack); | |||
There was a problem hiding this comment.
We can't do this, because the default error middleware which the express figures out is supposed to have 4 params, We need to compress just on this line or you can call next() which anyways doesn't make much sense
| @@ -130,7 +130,7 @@ function AddBlog() { | |||
| }); | |||
|
|
|||
| return (await postPromise).data; | |||
| } catch (error: any) { | |||
| } catch (error: unknown) { | |||
| if (isAxiosError(error)) { | |||
There was a problem hiding this comment.
Can you figure out if you can know it ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
modify the dark theme in the add blog page. and cleared the eslint error in both frontend and backend code.
Description
I have changed the dark theme in the add blog component at the same time i have changed the color of login and signup button to white and cleared the eslint error in both frontend and backend code.
Images
signin page
signup page
add blog page
Prerequisites